GH-50654: [C++] Support simdjson without exceptions by Reranko05 · Pull Request #50672 · apache/arrow

Reranko05 · 2026-07-28T03:38:44Z

Rationale for this change

This change enables building Arrow with SIMDJSON_EXCEPTIONS=0 by updating the JSON object parser to use simdjson's non-throwing API.

What changes are included?

Enable SIMDJSON_EXCEPTIONS=0 for the bundled simdjson dependency.
Replace uses of simdjson_result::value() in ObjectParser with the non-throwing get() API.
Preserve existing error handling by returning Arrow Status values on simdjson errors.

Are these changes tested?

Yes.

Fixes: #50654

GitHub Issue: [C++] Turn off exceptions in simdjson #50654

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Reranko05 · 2026-07-28T04:18:12Z

@kou @rok Could you review this when you have time? Thanks!

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

kou

+1

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

taepper · 2026-07-28T16:16:20Z

+    std::string_view str;
+    if (auto error = std::move(str_result).get(str)) {
+      return Status::Invalid("Error getting string for key '", key,
+                             "': ", simdjson::error_message(error));
+    }
+    return std::string(str);


#50653 adds

template <typename SimdjsonValueType> Result<SimdjsonValueType> GetJsonAs(sj::value& value) {

that already returns arrow::Results instead of error codes. This might simplify these type-casts

Thanks for the suggestions! I opened #50693 to track this cleanup after #50672 is merged.

Well, #50653 is merged now :)

I wanted to write after this PR is merged. Referenced the wrong PR. Fixed it.

taepper · 2026-07-28T16:24:49Z

@@ -102,7 +106,13 @@ class ObjectParser::Impl {
                               "': (code=", static_cast<int>(str_result.error()), ")");
      }

-      map.emplace(std::string(key), std::string(str_result.value()));
+      std::string_view str;
+      if (auto error = std::move(str_result).get(str)) {
+        return Status::Invalid("Error getting value for key '", std::string(key),
+                               "': ", simdjson::error_message(error));
+      }
+
+      map.emplace(std::string(key), std::string(str));


auto field has type simdjson_result<sj::field>. If we first resolve this to a sj::field, we do not need duplicated value checks for the unescaped_key and value.

Also, first asserting the value (L110), then type-checking the value (L98), is cleaner IMO. (It also works the other way around because simdjson provides overloads for many methods on its result type)

Note that for asserting the value and type-checking the value #50653 adds helper methods we might want to reuse

taepper · 2026-07-28T16:25:17Z

+    bool value;
+    if (auto error = std::move(bool_result).get(value)) {
+      return Status::Invalid("Error getting bool for key '", key,
+                             "': ", simdjson::error_message(error));
+    }


#50653 adds

template <typename SimdjsonValueType> Result<SimdjsonValueType> GetJsonAs(sj::value& value) {

that already returns arrow::Results instead of error codes. This might simplify these type-casts

kou · 2026-07-30T05:57:56Z

We should rebase on main before we merge this... This broke our CI...

taepper · 2026-07-30T06:04:59Z

We should rebase on main before we merge this... This broke our CI...

See #50732

### Rationale for this change The simdjson API has a throwing and non-throwing subset. #50672 activated a compiler flag that disables the throwing subset of the API, which broke some CI builds. ### What changes are included in this PR? This changes `json_write_internal.cc` and `from_string.cc` to use the non-throwing simdjson api ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: #50730 Authored-by: Alexander Taepper <alexander.taepper@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>

conbench-apache-arrow · 2026-07-31T06:09:45Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit bb0cf77.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Reranko05 requested a review from pitrou as a code owner July 28, 2026 03:38

Copilot AI review requested due to automatic review settings July 28, 2026 03:38

Copilot AI reviewed Jul 28, 2026

github-actions Bot added Component: C++ awaiting review Awaiting review labels Jul 28, 2026

kou reviewed Jul 28, 2026

View reviewed changes

Comment thread cpp/src/arrow/json/object_parser.cc Outdated

github-actions Bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jul 28, 2026

Copilot AI review requested due to automatic review settings July 28, 2026 06:40

Reranko05 force-pushed the gh-50654-excep-off branch from f94fe05 to fde573a Compare July 28, 2026 06:40

Copilot AI reviewed Jul 28, 2026

github-actions Bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jul 28, 2026

Reranko05 requested a review from kou July 28, 2026 07:15

kou reviewed Jul 28, 2026

View reviewed changes

Comment thread cpp/src/arrow/json/object_parser.cc Outdated

kou approved these changes Jul 28, 2026

View reviewed changes

Support simdjson without exceptions

92ae650

Copilot AI review requested due to automatic review settings July 28, 2026 08:41

Reranko05 force-pushed the gh-50654-excep-off branch from fde573a to 92ae650 Compare July 28, 2026 08:41

Copilot AI reviewed Jul 28, 2026

github-actions Bot added awaiting change review Awaiting change review awaiting merge Awaiting merge and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jul 28, 2026

Reranko05 requested a review from kou July 28, 2026 09:24

taepper reviewed Jul 28, 2026

View reviewed changes

Reranko05 mentioned this pull request Jul 28, 2026

[C++] Simplify ObjectParser simdjson result handling #50693

Open

kou merged commit bb0cf77 into apache:main Jul 30, 2026
60 of 64 checks passed

kou removed the awaiting merge Awaiting merge label Jul 30, 2026

kou mentioned this pull request Jul 30, 2026

[C++] Turn off exceptions in simdjson #50654

Closed

taepper mentioned this pull request Jul 30, 2026

[C++] Do not use throwing subset of <simdjson> api #50730

Closed

pitrou mentioned this pull request Jul 30, 2026

GH-50730: [C++] Do not use throwing <simdjson> api #50732

Merged

Uh oh!

Conversation

Reranko05 commented Jul 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included?

Are these changes tested?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reranko05 commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

taepper Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reranko05 Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pitrou Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reranko05 Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

taepper Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

taepper Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kou commented Jul 30, 2026

Uh oh!

taepper commented Jul 30, 2026

Uh oh!

conbench-apache-arrow Bot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Reranko05 commented Jul 28, 2026 •

edited by github-actions Bot

Loading

Reranko05 commented Jul 28, 2026 •

edited

Loading

Reranko05 Jul 28, 2026 •

edited

Loading